chore(codebuild): improve the doc for subnetSelection#26592
chore(codebuild): improve the doc for subnetSelection#26592mergify[bot] merged 6 commits intoaws:mainfrom
Conversation
I think this is giving vague instructions but don't really explain the underlying reasons. How about: |
|
According to Best practices for VPCs,
I believe if user selects public subnets, codebuild will not be able to access the public endpoints. So the option would be either PRIVATE_WITH_EGRESS or enable vpc endpoints. I have modified the suggested changes. Let me know if it works for you. |
rix0rrr
left a comment
There was a problem hiding this comment.
Good find on the CodeBuild exception, I didn't know that. Thanks!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
If
vpcis specified withsubnetSelectionundefined, according to this:aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/vpc.ts
Lines 655 to 660 in d5c64cb
CDK will look for
PRIVATE_WITH_EGRESS,PRIVATE_ISOLATED, andPUBLICin order. If customer does not havePRIVATE_WITH_EGRESSsubnets, they will need to have vpc endpoints if they need to access AWS services such as AWS Secrets Manager or Amazon ECR.This PR improves the doc to clarify.
Closes #.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license