Skip to content

fix(core): tags disappear if CDK app is bundled+minified#26181

Merged
mergify[bot] merged 4 commits intomainfrom
huijbers/tag-manager-renamed
Jul 3, 2023
Merged

fix(core): tags disappear if CDK app is bundled+minified#26181
mergify[bot] merged 4 commits intomainfrom
huijbers/tag-manager-renamed

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jun 30, 2023

Caused by a check for constructor.name which esbuild may rename. Replace with a checkable symbol.

Closes #26169.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Caused by a check for `constructor.name` which `esbuild` may rename.
Replace with a checkable symbol.

Closes #26169.
@rix0rrr rix0rrr requested a review from a team June 30, 2023 09:41
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 30, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 30, 2023 09:41
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Jun 30, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed bug This issue is a bug. p2 effort/medium Medium work item – several days of effort labels Jun 30, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 30, 2023
@rix0rrr rix0rrr changed the title fix(core): tags disappear if CDK library is bundled/minified fix(core): tags disappear if CDK app is bundled+minified Jun 30, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Jun 30, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dc3ef9b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1f81718 into main Jul 3, 2023
@mergify mergify bot deleted the huijbers/tag-manager-renamed branch July 3, 2023 15:36
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cdk-lib: Missing tags when synthesizing after bundling code with esbuild

4 participants