feat(core): support bundling for single non-archive file#26106
feat(core): support bundling for single non-archive file#26106mergify[bot] merged 12 commits intoaws:mainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: I did not find any place where the bundling type is documented. Is this a needed addition? |
| })).toThrow(/Bundling output directory is expected to include only a single file when `output` is set to `ARCHIVED` or `SINGLE_FILE`/); | ||
| }); | ||
|
|
||
| // TODO test here hoegertn |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| new IntegTest(app, 'IntegTest', { | ||
| testCases: [stack], | ||
| }); |
There was a problem hiding this comment.
Any chance you can add an assertions that checks the file is in the expected location and format, as opposed to being in a zip-archive?
There was a problem hiding this comment.
Might be easier to test that as a unit test though.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thanks @hoegertn ! Apologies this took a while. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds a possibility to use local bundling and let the final asset be one single file that is uploaded as-is.
This can be used for several types of assets, e.g. AppSync functions.
In contrast to Lambda, these functions to not expect the asset to be a zip file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license