fix(ecs): potential race condition on TaskRole default policy update with CfnService#26070
Merged
mergify[bot] merged 10 commits intoaws:mainfrom Jun 26, 2023
Merged
fix(ecs): potential race condition on TaskRole default policy update with CfnService#26070mergify[bot] merged 10 commits intoaws:mainfrom
mergify[bot] merged 10 commits intoaws:mainfrom
Conversation
|
|
corymhall
approved these changes
Jun 26, 2023
Contributor
corymhall
left a comment
There was a problem hiding this comment.
@lpizzinidev Great job! Thanks for following up on this 🙏🏻
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents potential race conditions on TaskRole default policy update in EC2 and Fargate services by adding a dependency on the TaskRole.
This will update the TaskRole and its children first and the service after.
Closes #24880.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license