fix(cli): deployment continues if ECR asset fails to build or publish#26060
fix(cli): deployment continues if ECR asset fails to build or publish#26060mergify[bot] merged 3 commits intomainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
left a comment
There was a problem hiding this comment.
I added some tests. They are semi-redundant in that they do not directly test the added code. Instead, they show that if buildSingleAsset or publishSingleAsset did throw an error, then that error would be properly reflected in the work graph. There's probably a better way to directly test, but this looks like the simplest path forward that still shows that the error messages will be sufficient.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #26048, fixes #25827.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license