Skip to content

feat(iot): add action to start Step Functions State Machine#26059

Merged
mergify[bot] merged 7 commits intoaws:mainfrom
jumic:iot-state-machine
Jun 30, 2023
Merged

feat(iot): add action to start Step Functions State Machine#26059
mergify[bot] merged 7 commits intoaws:mainfrom
jumic:iot-state-machine

Conversation

@jumic
Copy link
Copy Markdown
Contributor

@jumic jumic commented Jun 20, 2023

Add new IoT topic rule action to send IoT messages to Step Functions State Machines.

Closes #17698.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 20, 2023

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jun 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 20, 2023 15:44
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jun 20, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 20, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Jun 26, 2023
Copy link
Copy Markdown
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks great. Thank you for creating the PR.

I just have some comments.

@mergify mergify bot dismissed vinayak-kukreja’s stale review June 27, 2023 06:13

Pull request has been modified.

@jumic jumic requested a review from vinayak-kukreja June 27, 2023 16:12
@vinayak-kukreja
Copy link
Copy Markdown
Contributor

Thank you for addressing the feedback. This LGTM.

Getting a second opinion from @otaviomacedo.

otaviomacedo
otaviomacedo previously approved these changes Jun 28, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed stale reviews from otaviomacedo and vinayak-kukreja June 28, 2023 14:52

Pull request has been modified.

@vinayak-kukreja
Copy link
Copy Markdown
Contributor

Hey @jumic, looks like a merge from main failed. Let me know if you need help resolving the errors.

@jumic
Copy link
Copy Markdown
Contributor Author

jumic commented Jun 28, 2023

Hey @vinayak-kukreja, I merged the main branch again. The build is now successful.

@jumic jumic requested a review from vinayak-kukreja June 28, 2023 19:45
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6432653
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(iot): TopicRule action for Step Functions in AWS IoT

4 participants