feat(codebuild): Support for CodeBuild Image `aws/codebuild/amazonlinux2-x86_64-standard:5.0` by sktan · Pull Request #26058 · aws/aws-cdk

sktan · 2023-06-20T15:34:10Z

Added support for Amazon Linux 2023 CodeBuild Image:

https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

aws/codebuild/amazonlinux2-x86_64-standard:5.0

i.e you can now reference the latest codebuild image via the codebuild.LinuxBuildImage.AMAZON_LINUX_2_5 enum rather than having to resolve it manually like LinuxBuildImage.codeBuildImage('aws/codebuild/amazonlinux2-x86_64-standard:5.0')

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2023-06-20T15:34:20Z

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

sktan · 2023-06-20T15:41:06Z

Exemption Request

This is just adding a value to an enum which doesn't change any pre-existing behaviour

Tietew · 2023-06-21T05:58:12Z

The document says al2/standard/5.0 is Amazon Linux 2023.
The correct name might be AMAZON_LINUX_2023_5

sktan · 2023-06-21T06:07:00Z

The document says al2/standard/5.0 is Amazon Linux 2023. The correct name might be AMAZON_LINUX_2023_5

I did consider this actually, but ultimately went with the Image Identifier as:

That is the version number that's incrementing (might be confusing since the numbers won't be incrementing sequentially from 1 for future Amazon Linux distributions)
This identifier is shown to the user the AWS Console provides when selecting the option.

Maybe this should be revised by the codebuild team or we can just include both.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

vinayak-kukreja

Hey, this looks good to me.

Tagging @corymhall to get a second opinion for the PR.

vinayak-kukreja

Hey, I synced with Cory and have some feedback. Let me know if you need any clarifications.

...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts

Pull request has been modified.

sktan · 2023-06-28T00:38:48Z

@vinayak-kukreja Thanks for the comments, I've fixed it up and the new commit passed the CI tests

vinayak-kukreja

Hey, thank you for addressing the feedback. Just some minor comments.

vinayak-kukreja · 2023-06-28T18:37:40Z

...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts

+  constructor(scope: Construct, id: string) {
+    super(scope, id);
+
+    /// !show


Hey, could you also remove: /// !show and /// !hide.

fixed this too 😄

Pull request has been modified.

vinayak-kukreja

LGTM. Thank you for your contribution :)

mergify · 2023-07-03T22:51:59Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2023-07-03T23:20:56Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 6a48e16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-07-03T23:21:17Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

sktan added 2 commits June 20, 2023 15:30

Support for CodeBuild Amazon Linux 2023 Build Image

205521b

Fixed bad caps

9da5ea6

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 20, 2023

aws-cdk-automation requested a review from a team June 20, 2023 15:34

aws-cdk-automation previously requested changes Jun 20, 2023

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 20, 2023

sktan changed the title ~~feat(codebuild): Support for CodeBuild Amazon Linux 2023 Build Image~~ feat(codebuild): Support for CodeBuild aws/codebuild/amazonlinux2-x86_64-standard:5.0 Jun 20, 2023

sktan changed the title ~~feat(codebuild): Support for CodeBuild aws/codebuild/amazonlinux2-x86_64-standard:5.0~~ feat(codebuild): Support for CodeBuild Image aws/codebuild/amazonlinux2-x86_64-standard:5.0 Jun 20, 2023

Updated README to include new amazon linux 2:5.0 image

60de4d8

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 20, 2023

Added integration test for this

40f1fcb

sktan and others added 4 commits June 26, 2023 16:04

Fixed integ test folder

7dad0a8

Fixing tests

49484e3

Merge branch 'main' into feat/aws-codebuild/amazonlinux2023

6b31f8b

Removed renamed integration test

d1bfe93

vinayak-kukreja reviewed Jun 26, 2023

View reviewed changes

vinayak-kukreja previously requested changes Jun 27, 2023

View reviewed changes

...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts Outdated Show resolved Hide resolved

...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts Outdated Show resolved Hide resolved

vinayak-kukreja removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jun 27, 2023

Remove unneccesary comments and update stackUpdateWorkflow

cbec697

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 28, 2023

sktan requested a review from vinayak-kukreja June 28, 2023 05:37

vinayak-kukreja previously requested changes Jun 28, 2023

View reviewed changes

Removed unneeded comments

c1bf2da

sktan requested a review from vinayak-kukreja June 28, 2023 22:21

vinayak-kukreja approved these changes Jul 3, 2023

View reviewed changes

Merge branch 'main' into feat/aws-codebuild/amazonlinux2023

6a48e16

mergify bot merged commit bc029fe into aws:main Jul 3, 2023

sktan deleted the feat/aws-codebuild/amazonlinux2023 branch July 4, 2023 00:26

github-actions bot mentioned this pull request Jul 26, 2023

Monthly PRs metrics report - June 2023 #26516

Closed

Conversation

sktan commented Jun 20, 2023

Uh oh!

gitpod-io bot commented Jun 20, 2023

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

sktan commented Jun 20, 2023

Uh oh!

Tietew commented Jun 21, 2023

Uh oh!

sktan commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinayak-kukreja left a comment

Choose a reason for hiding this comment

Uh oh!

vinayak-kukreja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sktan commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinayak-kukreja left a comment

Choose a reason for hiding this comment

Uh oh!

vinayak-kukreja Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

sktan Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

vinayak-kukreja left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jul 3, 2023

Uh oh!

aws-cdk-automation commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jul 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sktan commented Jun 21, 2023 •

edited

Loading

sktan commented Jun 28, 2023 •

edited

Loading