Skip to content

feat(lambda): provide support for AWS Parameters and Secrets Extension for Lambda#25928

Merged
mergify[bot] merged 55 commits intomainfrom
colifran/params-and-secrets-lambda-extension
Jun 12, 2023
Merged

feat(lambda): provide support for AWS Parameters and Secrets Extension for Lambda#25928
mergify[bot] merged 55 commits intomainfrom
colifran/params-and-secrets-lambda-extension

Conversation

@colifran
Copy link
Copy Markdown
Contributor

@colifran colifran commented Jun 10, 2023 •
edited
Loading

This PR provides support for the AWS Parameters and Secrets Extension for Lambda functions. This extension will allow users to retrieve and cache AWS Secrets Manager secrets and AWS Parameter Store parameters in Lambda functions without using an SDK.

Note: Previous PR results in the go build breaking. This removed the circular dependency causing the go build to break:

[jsii-pacmak] [INFO] Found 1 modules to package
[jsii-pacmak] [INFO] Packaging NPM bundles
[jsii-pacmak] [INFO] Loading jsii assemblies and translations
[jsii-pacmak] [INFO] Packaging 'go' for aws-cdk-lib
[jsii-pacmak] [INFO] go finished
[jsii-pacmak] [INFO] Packaged. go (54.9s) | npm pack (5.4s) | load jsii (0.5s) | cleanup (0.0s)

Closes #23187

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Francis added 30 commits May 19, 2023 15:13
added interface for params and secrets extension configuration option…
ab0770a 
…s and added an enum for params and secrets logging level

Signed-off-by: Francis <colifran@amazon.com>
created initial getter for params and secrets extension lambda arn
dc5a38f 
Signed-off-by: Francis <colifran@amazon.com>
added some initial logic to create params and secrets layer and to ad…
36d4bb8 
…d environment variables based on config

Signed-off-by: Francis <colifran@amazon.com>
moved params and secrets extension lambda arn table to region-build d…
93553ff 
…irectory

Signed-off-by: Francis <colifran@amazon.com>
added readonly keyword to ParametersAndSecretsExtensionConfig interfa…
bba4e63 
…ce and added permissions to attachParametersAndSecretsExtension method

Signed-off-by: Francis <colifran@amazon.com>
refactored code and added a params-and-secrets-layers file - separati…
a721460 
…on of concerns

Signed-off-by: Francis <colifran@amazon.com>
initial implementation for _bind and some initial logic for configure…
d4ac1c5 
…ParamsAndSecretsExtension

Signed-off-by: Francis <colifran@amazon.com>
refactor
762b2d3 
Signed-off-by: Francis <colifran@amazon.com>
created initial params and secrets fact table and added code for regi…
d705559 
…stering fact

Signed-off-by: Francis <colifran@amazon.com>
registered params and secrets fact
a08b55b 
Signed-off-by: Francis <colifran@amazon.com>
completed registering fact and created getVersionArn logic
f8a22f1 
Signed-off-by: Francis <colifran@amazon.com>
made fromArchitecture static method and made lambda layern arn select…
7014351 
…able by architecture

Signed-off-by: Francis <colifran@amazon.com>
added permissions to configure params and secrets method
a688ef4 
Signed-off-by: Francis <colifran@amazon.com>
small refactoring and added all arns to fact table
9614604 
Signed-off-by: Francis <colifran@amazon.com>
removed test and added attribute to abstract class
2def06d 
Signed-off-by: Francis <colifran@amazon.com>
wip - unit tests
f8e6f34 
Signed-off-by: Francis <colifran@amazon.com>
wip
a13cf75 
Signed-off-by: Francis <colifran@amazon.com>
updated naming and added unit tests
2361ff0 
Signed-off-by: Francis <colifran@amazon.com>
corrected unit test and added more description to getVersionArn error…
ab603de 
… message

Signed-off-by: Francis <colifran@amazon.com>
docstrings and unit test logic
07c4d7d 
Signed-off-by: Francis <colifran@amazon.com>
added an options property to allow users to configure environment var…
9fb3e49 
…iables as part of the extension

Signed-off-by: Francis <colifran@amazon.com>
refactor
9759a41 
Signed-off-by: Francis <colifran@amazon.com>
wip
3e56c45 
Signed-off-by: Francis <colifran@amazon.com>
unit tests
c86d406 
Signed-off-by: Francis <colifran@amazon.com>
added validation for configuration options, added unit tests, updated…
581a737 
… region-info to include version

Signed-off-by: Francis <colifran@amazon.com>
unit tests for bad configuration options
f15ba2d 
Signed-off-by: Francis <colifran@amazon.com>
unit test for arm64 in unsupported region
06ab452 
Signed-off-by: Francis <colifran@amazon.com>
unit test for kms:Decrypt in execution pole
c09bbd4 
Signed-off-by: Francis <colifran@amazon.com>
unit test for multiple secrets
a8c4b3c 
Signed-off-by: Francis <colifran@amazon.com>
added some comments
8ae5edf 
Signed-off-by: Francis <colifran@amazon.com>
Francis and others added 10 commits May 30, 2023 10:00
integ tests and snapshots
9cd452e 
Signed-off-by: Francis <colifran@amazon.com>
@colifran
Merge branch 'main' into colifran/params-and-secrets-lambda-extension
8b0f1ff
updated version to correctly use 1.0.103
22cab5d 
Signed-off-by: Francis <colifran@amazon.com>
updated integ test and snapshots for extension version 1.0.103
c9275e1 
Signed-off-by: Francis <colifran@amazon.com>
@mergify
Merge branch 'main' into colifran/params-and-secrets-lambda-extension
5e1a67c
empty commit to re-run integ tests
19f9cbb 
Signed-off-by: Francis <colifran@amazon.com>
removed cyclic dependency
5cb363c 
Signed-off-by: Francis <colifran@amazon.com>
Merge branch 'main' into colifran/params-and-secrets-lambda-extension
d6f2808
removed dependency on secretsmanager and ssm - updated code and unit …
4a3692b 
…tests

Signed-off-by: Francis <colifran@amazon.com>
updated integ test code
765dc65 
Signed-off-by: Francis <colifran@amazon.com>
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 10, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2023 00:06
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jun 10, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 10, 2023
updated README to correctly display example of providing params and s…
7849d37 
…ecrets ARN

Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Jun 10, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 10, 2023
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Jun 10, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 568799c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4a3903f into main Jun 12, 2023
@mergify mergify bot deleted the colifran/params-and-secrets-lambda-extension branch June 12, 2023 12:02
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
@hassaku63 hassaku63 mentioned this pull request Jul 19, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(lambda): Make it easy to use "AWS Parameters and Secrets Lambda Extension" with Lambda Functions

3 participants

@colifran @aws-cdk-automation @otaviomacedo