feat(app-staging-synthesizer): clean up staging resources on deletion#25906
feat(app-staging-synthesizer): clean up staging resources on deletion#25906mergify[bot] merged 53 commits intomainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
packages/@aws-cdk/app-staging-synthesizer-alpha/scripts/airlift-custom-resource-bindings.sh
Outdated
Show resolved
Hide resolved
packages/custom-resource-bindings/scripts/build-and-minify-sources.js
Outdated
Show resolved
Hide resolved
packages/custom-resource-bindings/scripts/build-and-minify-sources.js
Outdated
Show resolved
Hide resolved
packages/custom-resource-bindings/scripts/build-and-minify-sources.js
Outdated
Show resolved
Hide resolved
packages/custom-resource-bindings/scripts/build-and-minify-sources.js
Outdated
Show resolved
Hide resolved
packages/custom-resource-bindings/scripts/build-and-minify-sources.js
Outdated
Show resolved
Hide resolved
| recFolderStructure(path.join(fileOrDir, i)); | ||
| } | ||
| } else { | ||
| if (path.extname(fileOrDir) === '.ts') { |
There was a problem hiding this comment.
Maybe even make this explicit with .lambda.ts ?
There was a problem hiding this comment.
I think we require the resulting file to be index.js
packages/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
closes #25722
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license