feat: update alpha modules to sdk v3#25895
Merged
mergify[bot] merged 18 commits intomainfrom Jun 30, 2023
Merged
Conversation
`@aws-sdk/types` dependency is required with a version locked to our `@aws-sdk/*` client libraries used in testing, otherwise type conflicts can occur at the mono-repo level.
|
|
…to feat/alpha-modules-sdk-v3
packages/@aws-cdk/aws-amplify-alpha/lib/asset-deployment-handler/handler.ts
Show resolved
Hide resolved
corymhall
suggested changes
Jun 12, 2023
Contributor
corymhall
left a comment
There was a problem hiding this comment.
I think we should update all the integ test that use these custom resources to
have diffAssets: true so that we have to rerun the integ tests.
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/base.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/lambda-handler/sdk.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
corymhall
approved these changes
Jun 30, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates alpha modules with custom resources to use NodeJS 18 and v3 of the AWS SDK. Since these CRs are pretty self-contained and safe to update, their handler code and runtime versions can be updated without any breakage for users.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license