Skip to content

fix(codebuild): add possibility to specify BUILD_GENERAL1_SMALL compute type with Linux GPU build image#25880

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
lpizzinidev:gh-25857
Jun 12, 2023
Merged

fix(codebuild): add possibility to specify BUILD_GENERAL1_SMALL compute type with Linux GPU build image#25880
mergify[bot] merged 2 commits intoaws:mainfrom
lpizzinidev:gh-25857

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

This fix allows specifying the BUILD_GENERAL1_SMALL compute type when using a Linux GPU to build an image as defined in the docs.

Closes #25857.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 7, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 7, 2023 07:53
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 7, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@lpizzinidev
Copy link
Copy Markdown
Contributor Author

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Exemption Request.
Let me know if changes to integration tests are needed.

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 7, 2023
@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 12, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 12, 2023 13:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ea95ee5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2d74a46 into aws:main Jun 12, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-codebuild: using SMALL compute type with GPU codebuild environment

3 participants