fix(app-mesh): Missing port property in gRPC routers matchers#25868
fix(app-mesh): Missing port property in gRPC routers matchers#25868mergify[bot] merged 16 commits intoaws:mainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
corymhall
left a comment
There was a problem hiding this comment.
@neovasili thanks for the PR! just 1 minor thing.
There was a problem hiding this comment.
yarn.lock shouldn't need to be updated.
12a4322 to
32509f5
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
nice! Allow edits from maintainers is already enabled 😄 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
As described in the related issue,
GrpcRouteMatchL2 construct was missingportproperty which is already present in the L1 constructCfnRoute.This PR adds the missing
portproperty toGrpcRouteMatchL2 construct and also addsportproperty toGrpcGatewayRouteMatchandHttpRouteMatchL2 constructs that were also missing it.The PR includes unit and integration tests expansion to cover this new property plus a reference to the property in the appmesh README file.
Closes #25810.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license