Skip to content

docs(elbv2): metricRequestCountPerTarget docstring points to correct replacement function#25762

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
khushail:propUpdated
Jun 12, 2023
Merged

docs(elbv2): metricRequestCountPerTarget docstring points to correct replacement function#25762
mergify[bot] merged 6 commits intoaws:mainfrom
khushail:propUpdated

Conversation

@khushail
Copy link
Copy Markdown
Contributor

@khushail khushail commented May 26, 2023 •
edited by kaizencc
Loading

Closes #25748.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 26, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 26, 2023 23:30
@github-actions github-actions bot added the p2 label May 26, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes May 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@khushail khushail changed the title (aws-cdk-lib.aws_elasticloadbalancingv2): updating the documentation chore: updating the documentation for aws_elasticloadbalancingv2 function May 26, 2023
@khushail khushail changed the title chore: updating the documentation for aws_elasticloadbalancingv2 function chore: updating the documentation for function in aws_elasticloadbalancingv2 May 26, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 26, 2023 23:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 26, 2023
@kaizencc kaizencc mentioned this pull request May 30, 2023
Closed
kaizencc
kaizencc previously approved these changes May 30, 2023
View reviewed changes
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label May 30, 2023
@mergify mergify bot dismissed kaizencc’s stale review May 30, 2023 21:04

Pull request has been modified.

@kaizencc kaizencc changed the title chore: updating the documentation for function in aws_elasticloadbalancingv2 docs(elbv2): metricRequestCountPerTarget docstring points to correct replacement function May 30, 2023
kaizencc
kaizencc previously approved these changes May 30, 2023
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review May 31, 2023 13:43

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 31, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9e9b78
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 72ea3ab into aws:main Jun 12, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@corymhall corymhall corymhall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib.aws_elasticloadbalancingv2): The documentation for the instead function is incorrect.

4 participants

@khushail @aws-cdk-automation @kaizencc @corymhall