fix(core): crossRegionReferences don't work across multiple regions#25384
fix(core): crossRegionReferences don't work across multiple regions#25384mergify[bot] merged 2 commits intoaws:mainfrom corymhall:corymhall/core/fix-export-writer-multi-region
Conversation
The first attempt to fix this in #25190 didn't work because it didn't account for the fact that when exporting to multiple regions, we create multiple `ExportWriter`s that all use the same provider (and provider role). This PR fixes that by adding the policy cross region ARNs directly to the custom resource provider (1 per stack) rather than the `ExportWriter` (multiple per stack). I also updated the test case to better account for this scenario. fixes #25377
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Naumel
left a comment
There was a problem hiding this comment.
Approving since the permissions do not change with the diff.
| Effect: 'Allow', | ||
| Resource: Lazy.list({ produce: () => Array.from(this.resourceArns) }), | ||
| Action: [ | ||
| 'ssm:DeleteParameters', |
There was a problem hiding this comment.
Is this required or can we https://docs.aws.amazon.com/systems-manager/latest/APIReference/API_PutParameter.html#API_PutParameter_RequestSyntax?
overwrite set to true flips the Put call from a create to an update.
| // get or create the export writer | ||
| const writerConstructName = makeUniqueId(['ExportsWriter', importStack.region]); | ||
| const exportReader = ExportWriter.getOrCreate(exportingStack, writerConstructName, { | ||
| const exportWriter = ExportWriter.getOrCreate(exportingStack, writerConstructName, { |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The first attempt to fix this in #25190 didn't work because it didn't account for the fact that when exporting to multiple regions, we create multiple
ExportWriters that all use the same provider (and provider role).This PR fixes that by adding the policy cross region ARNs directly to the custom resource provider (1 per stack) rather than the
ExportWriter(multiple per stack). I also updated the test case to better account for this scenario.fixes #25377
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license