fix(core): Add stage prefix to stack name shortening process#25359
fix(core): Add stage prefix to stack name shortening process#25359mergify[bot] merged 65 commits intoaws:mainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: The previous PR was exempt from adding integration tests |
…blo/fix-stack-name-too-long
…blo/fix-stack-name-too-long
|
Clarification Request: Can a maintainer confirm if this PR needs integration tests? |
|
Pls review ;_; |
…blo/fix-stack-name-too-long
…stodioPablo/aws-cdk into QustodioPablo/fix-stack-name-too-long
|
@TheRealAmazonKendra I reopened this PR adding a feature flag, could you add an exception for integration tests as in the previous PR? |
…blo/fix-stack-name-too-long
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There is an issue in the stack name generation process where the prefix generated from assembly's stage name is not taken into account when shortening a stack name to meet the requirement of being equal or less than 128 characters longs.
This can lead to generating an invalid stack name greater than 128 characters: since the stack name is shortened to 128 characters, when the prefix is added, the limit is exceeded.
Current solution:
Fixes #23628
NOTE: This PR was previously opened, but it was merged before I was able to add a feature flag, which ended up adding breaking changes and the changes of the PR were rolled back. Old PR: #24443