Skip to content

feat(stepfunctions): support string and file definitions#24900

Closed
hoegertn wants to merge 9 commits intoaws:mainfrom
hoegertn:hoegertn-sfn-asl
Closed

feat(stepfunctions): support string and file definitions#24900
hoegertn wants to merge 9 commits intoaws:mainfrom
hoegertn:hoegertn-sfn-asl

Conversation

@hoegertn
Copy link
Copy Markdown
Contributor

@hoegertn hoegertn commented Apr 1, 2023 •
edited
Loading

This change to AWS CDK will allow for the easier design of workflows by using the workflow studio. The visual representation of workflows is more attractive and easier to understand for developers and business people. Additionally, this change will address related issues in the CDK, improving the overall functionality and user experience. Adding the definitionBody and definitionSubstitutions props and the union-like class DefinitionBody will make it easier to define workflows using this tool by allowing users to define workflows in different ways, such as from an external file or a string.

Closes #8146.
Refs: #18880

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

  • Base implementation
  • Unit tests
  • Integ tests
  • Readme update

@github-actions github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1 labels Apr 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2023 12:42
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Apr 1, 2023
@hoegertn
Copy link
Copy Markdown
Contributor Author

hoegertn commented Apr 1, 2023

Tests will follow soon. Need to make sure I can compile as Gitpod now crashes with OOM errors after the restructure.

aws-cdk-automation
aws-cdk-automation requested changes Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 23, 2023

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@hoegertn
Copy link
Copy Markdown
Contributor Author

hoegertn commented Apr 23, 2023

I am still working on it.

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 23, 2023

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 1, 2023

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 1, 2023
@mrgrain mrgrain reopened this May 1, 2023
@hoegertn hoegertn marked this pull request as ready for review May 1, 2023 19:23
@hoegertn
Copy link
Copy Markdown
Contributor Author

hoegertn commented May 1, 2023 •
edited
Loading

I was not able to run the integ test. Gitpod threw errors about not finding some modules.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 1, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f6a5d6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 1, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1421365
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 2, 2023

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@mrgrain mrgrain reopened this May 2, 2023
@mrgrain mrgrain removed the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 2, 2023
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented May 2, 2023

I was not able to run the integ test. Gitpod threw errors about not finding some modules.

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label May 2, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 3, 2023

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 3, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 3, 2023

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aidansteele
Copy link
Copy Markdown

aidansteele commented May 10, 2023

@hoegertn This looks good, I hope to see it merged. I'm re-familiarising myself with CDK (I haven't used it for a while) so this might be a silly question: will it also work with state machine definitions authored in YAML? Or only JSON?

@hoegertn hoegertn mentioned this pull request May 10, 2023
Closed
4 tasks
@hoegertn hoegertn mentioned this pull request Jun 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StateMachine - support for definition string or JSON

4 participants

@hoegertn @aws-cdk-automation @mrgrain @aidansteele