feat(ecs): Alarm-based Rollbacks adding new datastructure,Constructor, enableDeploymentAlarms and MetricDeploymentAlarms#24182
feat(ecs): Alarm-based Rollbacks adding new datastructure,Constructor, enableDeploymentAlarms and MetricDeploymentAlarms#24182
Conversation
|
|
499ac18 to
4a87429
Compare
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
thanks for addressing the review comments 😬 let's make sure the codebuild check passes |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
bvtujo
left a comment
There was a problem hiding this comment.
LGTM. My only remaining comment is that we should probably not merge this into main yet, but instead use this branch as a feature branch. You should base your next PRs on this branch so that we can merge all the changes for alarm based rollbacks into main in one fell swoop and we don't run the risk of partially releasing this feature.
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
|
Adding a new interface, deploymentAlarmConfig, to allow customers to use existing alarms when the services are constructed.
Enable Deployment Alarms which take advantage of arbitrary alarms and configure them after service initialization.
Add an alarm based on ECS metric which appended to the list of deployment alarms at synthesis time
threshold value 85evaluationPeriods value 3Reference documentation : https://aws.amazon.com/blogs/containers/automate-rollbacks-for-amazon-ecs-rolling-deployments-with-cloudwatch-alarms/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license