Skip to content

fix(iam): SamlConsolePrincipal does not work in China #22091#24034

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
zorrofox:fix-iam-SamlConsolePrincipal-22091
Feb 10, 2023
Merged

fix(iam): SamlConsolePrincipal does not work in China #22091#24034
mergify[bot] merged 6 commits intoaws:mainfrom
zorrofox:fix-iam-SamlConsolePrincipal-22091

Conversation

@zorrofox
Copy link
Copy Markdown
Contributor

@zorrofox zorrofox commented Feb 6, 2023 •
edited
Loading

Support SamlConsolePrincipal for China and GOV partitions.

Closes #22091.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 6, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Feb 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2023 14:13
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 6, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 6, 2023 16:08

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@zorrofox zorrofox marked this pull request as ready for review February 7, 2023 00:51
TheRealAmazonKendra
TheRealAmazonKendra approved these changes Feb 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! Thank you for catching this!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 10, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 819bbe4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2902043 into aws:main Feb 10, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tonnico tonnico mentioned this pull request Feb 21, 2023
Closed
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iam: SamlConsolePrincipal does not work in China

3 participants

@zorrofox @aws-cdk-automation @TheRealAmazonKendra