fix(lambda): avoid OperationAbortedException when using log retention#2237
Merged
eladb merged 2 commits intoaws:masterfrom Apr 11, 2019
Merged
fix(lambda): avoid OperationAbortedException when using log retention#2237eladb merged 2 commits intoaws:masterfrom
eladb merged 2 commits intoaws:masterfrom
Conversation
If multiple LogRetention constructs are present in the stack, they will try to act on the provider's log group at the same time. This can sometime result in an OperationAbortedException. To avoid this and because this operation is not critical it is better to catch all errors when acting on the provider's log group
eladb
reviewed
Apr 10, 2019
| // same time. This can sometime result in an OperationAbortedException. To | ||
| // avoid this and because this operation is not critical we catch all errors. | ||
| try { | ||
| await createLogGroupSafe(`/aws/lambda/${context.functionName}`); |
Contributor
There was a problem hiding this comment.
What am I missing? Where is the part that sends the response to cloudformation?
Contributor
Author
There was a problem hiding this comment.
This is only to catch errors when setting the log retention on the lambda provider's log group of the custom resource not the log we are targeting, it's an internal try/catch. The external one still exists.
Contributor
Author
There was a problem hiding this comment.
We don't want to fail the whole process if setting the retention policy of 1 day on the provider's log group (singleton fn) fails.
Contributor
There was a problem hiding this comment.
ok. thanks for the clarification. missed that
eladb
suggested changes
Apr 10, 2019
Contributor
eladb
left a comment
There was a problem hiding this comment.
Can you please add a unit test?
eladb
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple LogRetention constructs are present in the stack, they will try to
act on the provider's log group at the same time. This can sometime result in
an OperationAbortedException. To avoid this and because this operation is not
critical it is better to catch all errors when acting on the provider's log
group
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.