Skip to content

feat(core): verify CfnOutput has a value and fix VPC export#2219

Merged
eladb merged 2 commits intomasterfrom
benisrae/verify-cfnoutput-value
Apr 10, 2019
Merged

feat(core): verify CfnOutput has a value and fix VPC export#2219
eladb merged 2 commits intomasterfrom
benisrae/verify-cfnoutput-value

Conversation

@eladb
Copy link
Copy Markdown
Contributor

@eladb eladb commented Apr 10, 2019 •
edited
Loading

Throw an error if value is undefined when defining a CfnOutput.

Fixes #2012 such that a VPC can be exported without a VPN gateway (there
is already unit test coverage).

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

feat(core): verify CfnOutput has a value and fix VPC export
d250c0b 
Throw an error if `value` is undefined when defining a `CfnOutput`.

Fixes #2012 such that a VPC can be exported without a VPN gateway (there
is already unit test coverage).
@eladb eladb requested a review from a team as a code owner April 10, 2019 13:40
@eladb eladb merged commit 9e87661 into master Apr 10, 2019
@eladb eladb deleted the benisrae/verify-cfnoutput-value branch April 10, 2019 20:39
@jogold jogold mentioned this pull request Apr 15, 2019
Closed
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

+1 more reviewer

@RomainMuller RomainMuller RomainMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdk.Output should validate that it is non-empty

4 participants

@eladb @RomainMuller @rix0rrr @NGL321