fix(aws-lambda): fail fast if a reserved environment variable is specified#22039
fix(aws-lambda): fail fast if a reserved environment variable is specified#22039mergify[bot] merged 2 commits intoaws:mainfrom joelcox22:main
Conversation
|
|
corymhall
left a comment
There was a problem hiding this comment.
Please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process (See Contributing Guide, Pull Requests (https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request))
|
Thanks for the feedback. PR description is now updated with more details and explaining my thought process 👍🏻 This is definitely a low priority PR - it's just a minor developer experience improvement for an edge case most developers probably won't even run into 😅 |
corymhall
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Looks great!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I've found myself several times without thinking specifying
AWS_REGIONas an environment variable explicitly when writing a lambda function that needed to know the region, and only found it was problemattic and unnecessary at cloudformation deployment time.This change adds a simple error to enable faster failures during development when a developer specifies a reserved environment variable name - it's purely a convenience change to help avoiding wasting time waiting for a deployment and rollback in an edge case where the developer is making a clear error.
This does not reference any existing issue.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license