Core: Duration ISO-8601 docs links not French#21922
Merged
mergify[bot] merged 1 commit intoaws:mainfrom Sep 5, 2022
Merged
Conversation
|
|
09c3532 to
cd4b393
Compare
otaviomacedo
approved these changes
Sep 5, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the links on https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_core.Duration.html and https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.Duration.html took me to the French-language version the ISO site, https://www.iso.org/fr/standard/70907.html, which surprised me.
This changes that to remove
/frfrom the URL. (I haven't tested, but this might default to the right language for a user's browser, or always show English, but I think either of those are less surprising, given the rest of the CDK's docs are in English.)All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license