feat(batch): add propagate tags prop in job definition#21904
feat(batch): add propagate tags prop in job definition#21904mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
|
|
|
Linter is failing as it wants a README change, not sure if this property warrants that? |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
I think this is likely OK to not include a README update, but this is still going to fail on lack of integration tests. That we will need before we can approve/merge this.
| * If no value is specified, the tags aren't propagated. | ||
| * Tags can only be propagated to the tasks during task creation. For tags with the same name, | ||
| * job tags are given priority over job definitions tags. | ||
| * If the total number of combined tags from the job and job definition is over 50, the job is moved to the `FAILED` state. |
There was a problem hiding this comment.
Is this validation we can do at synth time instead of letting the job fail at deploy time? If so, it should be added.
There was a problem hiding this comment.
I'm not aware of a way to get the tag count of a construct; the current Tag aspect API only offers the ability to add/remove tags. If you have any ideas happy to dig deeper.
There was a problem hiding this comment.
Bummer, that's OK.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes: #21740
Add support for propagateTags to the CDK construct.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license