Skip to content

feat: compress aws-cdk-lib tablet file#21854

Merged
mergify[bot] merged 2 commits intomainfrom
conroy/tablets
Sep 2, 2022
Merged

feat: compress aws-cdk-lib tablet file#21854
mergify[bot] merged 2 commits intomainfrom
conroy/tablets

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Aug 31, 2022

This is part of the Reduce Module Size project. Most of the heavy lifting is done in jsii, this PR simply turns on the feature.

I have tested this in our test pipeline and can confirm that the build output from there can be successfully ingested by contruct hub with transliterated examples in every language. Afaik, the tablet file included in the aws-cdk-lib package is only for construct hub, because reproducing the tablet file would take ~3 hours.

Title is a feat so that it shows up in the changelog; there are no unit or integ tests that can be run to demonstrate it is working.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Aug 31, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 31, 2022

@github-actions github-actions bot added the p2 label Aug 31, 2022
@kaizencc
Copy link
Copy Markdown
Contributor Author

kaizencc commented Aug 31, 2022

do-not-merge because I want to make sure my changes go through the construct hub pipeline first.

edit: all good now.

@aws-cdk-automation aws-cdk-automation requested a review from a team August 31, 2022 15:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 31, 2022
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/do-not-merge This PR should not be merged at this time. labels Sep 1, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 599c36a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5a3db2d into main Sep 2, 2022
@mergify mergify bot deleted the conroy/tablets branch September 2, 2022 06:05
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants