fix(aws-cdk): cdk bootstrap print JSON template when using --json option#21852
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Aug 31, 2022
Merged
fix(aws-cdk): cdk bootstrap print JSON template when using --json option#21852mergify[bot] merged 4 commits intoaws:mainfrom
mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue #21456.
Added support of
--jsonoption forcdk bootstrap --show-templatecommand.cdk bootstrap --show-template- will print YAML templatecdk bootstrap --show-template --json- will print JSON templateHow I tested it locally?
Prepared a package with fix with
yarn packageand installed withnpm install -g dist/js/aws-cdk-0.0.0.tgzReproduced steps from the bug (aws-cdk): cdk bootstrap prints YAML template even when using --json option #21456
Ensured that the issue is fixed
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license