Skip to content

chore(docs): clarify use of isOrganizationTrail#21824

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
corymhall:corymhall/fix-cloudtrail-docs
Aug 30, 2022
Merged

chore(docs): clarify use of isOrganizationTrail#21824
mergify[bot] merged 2 commits intoaws:mainfrom
corymhall:corymhall/fix-cloudtrail-docs

Conversation

@corymhall
Copy link
Copy Markdown
Contributor

If isOrganizationTrail is set to true, but the current AWS account
is not the management account then CloudFormation will throw an error.

You cannot configure or manage trails for an organization because this action requires being signed in with the management account.

Also remove the integration test that was added for this feature since
in order to test this you would need access to an AWS organization
management account and access to create/delete an organization trail.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

If `isOrganizationTrail` is set to `true`, but the current AWS account
is _not_ the management account then CloudFormation will throw an error.

`You cannot configure or manage trails for an organization because this action requires being signed in with the management account.`

Also remove the integration test that was added for this feature since
in order to test this you would need access to an AWS organization
management account _and_ access to create/delete an organization trail.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 30, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2022 12:48
@github-actions github-actions bot added the p2 label Aug 30, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 30, 2022
Copy link
Copy Markdown
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning checks out

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 34f1d91
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 82ce4a1 into aws:main Aug 30, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants