fix(integ): write assertion stack name to integ manifest#21809
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Aug 30, 2022
corymhall:corymhall/runner/fix-assertion-stack
Merged
fix(integ): write assertion stack name to integ manifest#21809mergify[bot] merged 4 commits intoaws:mainfrom corymhall:corymhall/runner/fix-assertion-stack
mergify[bot] merged 4 commits intoaws:mainfrom
corymhall:corymhall/runner/fix-assertion-stack
Conversation
In #21646 we updated the `assertionStack` value to be the `node.id` of the assertion stack since that is what the CDK CLI requires to deploy the stack. The change in #21646 fixed that bug, but it introduced a new one where the assertion results are no longer read and reported on by the integ-runner. The integ-runner reads the results of the assertions from the stack outputs which are written to a file (with `cdk deploy --output `assertion-results.json`). The outputs use the stack _name_ not the _node.id_. As a result, the integ-runner was looking for outputs for an invalid stack name. This PR fixes that by: - Adding `assertionStackName` property to the `integ.json` manifest - Updates the integ-runner to use the `assertionsStackName` to lookup the assertion results. - Add reporting on assertion results (previously only reported failures). - Updates all integ snapshots which currently use assertions.
|
|
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Naumel
approved these changes
Aug 30, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #21646 we updated the
assertionStackvalue to be thenode.idofthe assertion stack since that is what the CDK CLI requires to deploy
the stack.
The change in #21646 fixed that bug, but it introduced a new one where the
assertion results are no longer read and reported on by the
integ-runner. The integ-runner reads the results of the assertions from
the stack outputs which are written to a file (with
cdk deploy --outputassertion-results.json`). The outputs use the stack name not thenode.id. As a result, the integ-runner was looking for outputs for an
invalid stack name.
This PR fixes that by:
assertionStackNameproperty to theinteg.jsonmanifestassertionsStackNameto lookupthe assertion results.
failures).
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license