Skip to content

fix(integ-runner): array arguments aren't recognizing multiple options#21763

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
corymhall:corymhall/integ-runner/arrays
Aug 25, 2022
Merged

fix(integ-runner): array arguments aren't recognizing multiple options#21763
mergify[bot] merged 2 commits intoaws:mainfrom
corymhall:corymhall/integ-runner/arrays

Conversation

@corymhall
Copy link
Copy Markdown
Contributor

I don't know why I was specifying nargs: 1 for array arguments. This
tells yargs to only accept a single argument. You can no provide
multiple options, i.e.

yarn integ --regions us-east-1 us-east-2

re #20384


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

I don't know why I was specifying `nargs: 1` for array arguments. This
tells yargs to only accept a single argument. You can no provide
multiple options, i.e.

```
yarn integ --regions us-east-1 us-east-2
```

re #20384
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 25, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 25, 2022
@github-actions github-actions bot added the p2 label Aug 25, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 25, 2022 18:45
@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-test The PR linter will not require test changes label Aug 25, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 350f648
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d942324 into aws:main Aug 25, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@corymhall corymhall mentioned this pull request Sep 1, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants