feat(core): Fn::ToJsonString and Fn::Length intrinsic functions#21749
feat(core): Fn::ToJsonString and Fn::Length intrinsic functions#21749mergify[bot] merged 5 commits intoaws:mainfrom
Fn::ToJsonString and Fn::Length intrinsic functions#21749Conversation
Add support for `Fn::ToJsonString`, the `AWS::LanguageExtensions` is automatically added. See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ToJsonString.html
|
|
Fn::ToJsonString intrisic functionFn::ToJsonString intrinsic function
Fn::ToJsonString intrinsic functionFn::ToJsonString and Fn::Length intrinsic functions
| * | ||
| * @param array The array you want to return the number of elements from | ||
| */ | ||
| public static len(array: any): number { |
There was a problem hiding this comment.
cannot do public static length here.
Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'Fn'.ts(2699)
|
Needs |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Can you explain why you think that integ tests aren't needed here? I think it would probably be good to add that test coverage.
There are currently no integ tests in |
Hmm. I don't like that we don't have any tests for core, but adding them would very much be out of scope for this PR. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add support for
Fn::ToJsonStringandFn::Length.The
AWS::LanguageExtensionstransform is automatically added.See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ToJsonString.html
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-length.html
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-transform.html
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license