fix(ecs): secretToken required but declared as optional#21745
fix(ecs): secretToken required but declared as optional#21745mergify[bot] merged 5 commits intomainfrom
Conversation
|
|
…g deprecated prop
corymhall
left a comment
There was a problem hiding this comment.
I haven't looked into this too much, but since we don't backport code to v1, the code on main will only be released to v2. That should make updating this much easier.
|
Great, I'll try making this prop required then |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Looks good to me!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
tokenis no longer a valid option in v2, sosecretTokenis required by virtue of needing to provide at least one oftokenorsecretTokenRemoved test which checks for error because
secretTokenis now required so we cannot check for error, even withtestDeprecatedto my knowledgefixes #21744
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license