docs: ec2: Add documentation to the vpcEndpointDnsEntries prop#21701
docs: ec2: Add documentation to the vpcEndpointDnsEntries prop#21701mergify[bot] merged 5 commits intoaws:mainfrom
vpcEndpointDnsEntries prop#21701Conversation
|
|
corymhall
left a comment
There was a problem hiding this comment.
Very helpful! Just one suggestion to add the rest of the CFN docs since I think the examples are beneficial.
| * The DNS entries for the interface VPC endpoint. | ||
| * Each entry is a combination of the hosted zone ID and the DNS name. | ||
| * The entries are ordered as follows: regional public DNS, zonal public DNS, private DNS, and wildcard DNS. | ||
| * This order is not enforced for AWS Marketplace services. |
There was a problem hiding this comment.
| * This order is not enforced for AWS Marketplace services. | |
| * This order is not enforced for AWS Marketplace services. | |
| * | |
| * The following is an example. In the first entry, the hosted zone ID is Z1HUB23UULQXV | |
| * and the DNS name is vpce-01abc23456de78f9g-12abccd3.ec2.us-east-1.vpce.amazonaws.com. | |
| * | |
| * ["Z1HUB23UULQXV:vpce-01abc23456de78f9g-12abccd3.ec2.us-east-1.vpce.amazonaws.com", | |
| * "Z1HUB23UULQXV:vpce-01abc23456de78f9g-12abccd3-us-east-1a.ec2.us-east-1.vpce.amazonaws.com", | |
| * "Z1C12344VYDITB0:ec2.us-east-1.amazonaws.com"] | |
| * | |
| * If you update the PrivateDnsEnabled or SubnetIds properties, the DNS entries in the list will change. |
There was a problem hiding this comment.
Don't forget to backquote these code samples for Markdown
There was a problem hiding this comment.
@rix0rrr can you please clarify what you mean? You mean I should surround the sample with ```...```?
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I mistakenly assumed this prop would contain the list of DNS names and did not realize it is actually a list of the hosted zone ID and the DNS name separated by
:. This change includes a part of the CloudFormation documentation to the attribute to help others avoid this mistake.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license