Skip to content

feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget #21684

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
ackjewtn:add-cw-sparkline
Aug 22, 2022
Merged

feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget #21684
mergify[bot] merged 4 commits intoaws:mainfrom
ackjewtn:add-cw-sparkline

Conversation

@ackjewtn
Copy link
Copy Markdown
Contributor

@ackjewtn ackjewtn commented Aug 19, 2022

Adds configuration option for enabling sparkline in SingleValueWidget.

Fixes #21683

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 19, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Aug 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 19, 2022 12:47
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(aws-cloudwatch): Add support for sparkline graphs in SingleValueWidget feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget Aug 22, 2022
TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This looks good, we'll just need a README update and an integ test for this change.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 22, 2022 09:30

Pull request has been modified.

@ackjewtn
Copy link
Copy Markdown
Contributor Author

ackjewtn commented Aug 22, 2022

Thanks for the feedback @TheRealAmazonKendra - let me know if anything more is needed now

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 22, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cf94911
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cf5d115 into aws:main Aug 22, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra left review comments

+1 more reviewer

@corymhall corymhall corymhall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-cloudwatch): (sparkline for SingleValueWidget)

4 participants

@ackjewtn @aws-cdk-automation @corymhall @TheRealAmazonKendra