Skip to content

chore(s3-deployment): update failing integ tests#21631

Merged
mergify[bot] merged 1 commit intomainfrom
TheRealAmazonKendra/s3-deployment-test-fix
Aug 17, 2022
Merged

chore(s3-deployment): update failing integ tests#21631
mergify[bot] merged 1 commit intomainfrom
TheRealAmazonKendra/s3-deployment-test-fix

Conversation

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

The resources in these tests were colliding, causing failures. This change removes those collisions and
updates the tests so they pass when run locally.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The resources in these tests were colliding, causing failures. This change removes those collisions and
updates the tests so they pass when run locally.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 17, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2022 00:44
@github-actions github-actions bot added the p2 label Aug 17, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b1657f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Copy Markdown
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 17, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 17, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4268547 into main Aug 17, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/s3-deployment-test-fix branch August 17, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants