feat(cloudtrail): add configuration for IsOrganizationTrail#21625
feat(cloudtrail): add configuration for IsOrganizationTrail#21625mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
|
|
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
I think I would actually like a README update on this because the CloudFormation documentation isn't clear enough. I would have been inclined to agree with you if it hadn't taken me multiple times reading it to understand what the actual behavior was.
| cloudWatchLogsRoleArn: logsRole?.roleArn, | ||
| snsTopicName: this.topic?.topicName, | ||
| eventSelectors: this.eventSelectors, | ||
| isOrganizationTrail: props.isOrganizationTrail ?? false, |
There was a problem hiding this comment.
What's the behavior here if the account isn't the owner of an organization and this gets set to true? Does it just fail silently? If so, do we have a way to validate that the account is actually the owner of an organization?
Pull request has been modified.
|
@TheRealAmazonKendra I have added an entry in the README, updated the docstring and implemented your suggestion to not use the |
I'm not sure that there is a good way without introducing a LOT of extra complexity to this. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #21578
Please add
pr-linter/exempt-readmelabel since this property needs no entry in the README imho.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license