chore(cloud9): fix integ test that cannot pass#21561
Merged
mergify[bot] merged 2 commits intomainfrom Aug 11, 2022
Merged
Conversation
This integ test cannot pass using because it requires setup of resources ahead of time that the L1 construct does not handle. works just fine. A note has been added to the enum that a role and instance profile must be setup beforehand if it is selected.
|
|
corymhall
approved these changes
Aug 11, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Author
|
@Mergifyio requeue |
Contributor
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integ test cannot pass using
CONNECT_SSMbecause it requires setup of resourcesahead of time that the L1 construct does not handle. Because roles use eventual consistency,
just adding the role to the test isn't a good solution.
CONNECT_SSHworks just fine.A note has been added to the
ConnectionType.CONNECT_SSMenum that a role and instanceprofile must be setup beforehand if it is selected. Eventually if/when an L2 construct is created
we should handle this setup.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license