Skip to content

Revert "fix(ecs-patterns): memory limit is not set at the container level"#21530

Merged
mergify[bot] merged 2 commits intomainfrom
TheRealAmazonKendra/ecs-patterns-revert
Aug 10, 2022
Merged

Revert "fix(ecs-patterns): memory limit is not set at the container level"#21530
mergify[bot] merged 2 commits intomainfrom
TheRealAmazonKendra/ecs-patterns-revert

Conversation

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

This reverts #21201 due to #21484: Recent update breaks FargateService L3 constructs which have added additional containers to the task definition

Closes #21484
Re-opens #13127


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 10, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 10, 2022 05:42
@github-actions github-actions bot added bug This issue is a bug. p1 labels Aug 10, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 10, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb57954
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 605cc62 into main Aug 10, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/ecs-patterns-revert branch August 10, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(ecs-patterns): Recent update breaks FargateService L3 constructs which have added additional containers to the task definition

3 participants