feat(ecs-patterns): refactor fargate interfaces and add support for runtimePlatform#21529
Conversation
|
|
|
@michaeldrey I don't think I have any notes here. Once you add in the README update, this seems like a no brainer and like it's just ready to go. I suppose I'd like it if you added the other tests into this one that you had in the closed one, but those might(?) be redundant with this refactor. I am changing this to a feat since it's adding functionality that we'd want in the changelog, but I have no requested changes to the code at this time. |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Just putting this in changes requested so I see when it's been updated.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Stemming from #20756, currently there are a lot of duplicated Fargate props throughout the library ie
cpu,memory. This can make adding Fargate properties tedious as you have to add them into every Fargate type.This PR introduces
FargateServiceBasePropswhich will hold all of the common Fargate properties and allows all Fargate variations to inherit from.As an example, I have added in
runtimePlatformto all Fargate services.I still need to make a small README update, but want to get this pushed up for thoughts/suggestions/feedback.
closes #20756 #18462
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license