fix(cloudfront): truncate long ResponseHeaderPolicy names#21525
fix(cloudfront): truncate long ResponseHeaderPolicy names#21525mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
|
|
packages/@aws-cdk/aws-cloudfront/lib/response-headers-policy.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
packages/@aws-cdk/aws-cloudfront/lib/response-headers-policy.ts
Outdated
Show resolved
Hide resolved
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
One quick question: does this have the potential to create breaking changes for existing resources? I think no, but I'm not 100% positive.
packages/@aws-cdk/aws-cloudfront/lib/response-headers-policy.ts
Outdated
Show resolved
Hide resolved
|
@TheRealAmazonKendra, the Name property can be updated without replacement, it looks like. I think the only potential for breaking existing resources would be if someone managed to create a 129-character policy name (which appears to be allowed, but is not documented) and imported it outside of CDK by name somewhere else. It feels like 129 is so random (seems like it should be 128), so that's why I truncated to 128. IMO this scenario's pretty unlikely, but it is technically possible. |
Cool, thanks for the verification. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #21524
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license