fix(kms): imported key ignores environment from arn#21519
Conversation
|
|
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Given that this issue wasn't picked up by an integration test, I think one should be added to verify the fix.
|
I don't believe this needs an integ test. It's also impossible to integ test since it would require a pre-existing kms Key to be referenced with |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@Mergifyio update |
|
@Mergifyio requeue |
1 similar comment
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Fixes #21464. KMS keys imported using
fromKeyArn()currently take the environment of the stack, not the environment from the arn.This PR follows the precedent set in #19026 and #18255. It is essentially the same code change and tests. Ideally, we would have a mechanism for testing all
fromXxxArnAPIs to ensure they have the correct behavior. There are still many places where it does not. However, given the significant overhead of creating such a mechanism, I'm creating this one-off PR to unblock users in KMS.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license