Hey @huyphan Could you share your reasoning why you've chosen Option 1 over Option 2 (as per the issue)?

API elements with incompatible changes:
err  - PROP @aws-cdk/cx-api.AssetManifestArtifact.requiresBootstrapStackVersion: type Optional<number> (formerly number): output type is now optional [changed-type:@aws-cdk/cx-api.AssetManifestArtifact.requiresBootstrapStackVersion]
@aws-cdk/region-info... OK.
Some packages seem to have undergone breaking API changes. Please avoid.

Changing number to number | boolean is just as much of a breaking change as number | undefined is (which ?: number basically comes down to, more or less).

Given that, and since we are the only users of this code anyway, I'm okay with this change. It will break ~ 0 people.

(Watch me regret that stance as this change will bring customers out of the woodwork who this breaks 😅)

The only real alternative is { requiredVersion: number; justKiddingDisregardVersion?: boolean }, which I'd like to avoid if we can. If we end up breaking someone, we can always still move to that.

Even if there's anyone affected by this breaking change, the impact is negligible -- instead of failing early, the CLI will fail a bit later when it tries to make use of the resources in the bootstrap stack (e.g. uploading assets to the S3 bucket or the ECR repository). But all of that happened before a stack deployment, so it wouldn't affect a service stack.

Also, that scenario only happens when the user (1) uses a custom synthesizer which (2) makes use of the new-style bootstrap stack but (3) does not explicit specify that it needs a new-style bootstrap stack. This is a wrong logic anyway.

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 95bf193
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).