Skip to content

docs(core): clarify exclude option on file and asset operations#21517

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
mrgrain:docs/asset-options
Aug 9, 2022
Merged

docs(core): clarify exclude option on file and asset operations#21517
mergify[bot] merged 2 commits intoaws:mainfrom
mrgrain:docs/asset-options

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Aug 9, 2022

It is currently not obvious that exclude is ignored for bundling via the bundling prop.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 9, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 9, 2022 09:48
@github-actions github-actions bot added the p2 label Aug 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 9, 2022
@mrgrain mrgrain force-pushed the docs/asset-options branch from c0d1eac to ce12478 Compare August 9, 2022 09:49
@mrgrain mrgrain marked this pull request as ready for review August 9, 2022 10:03
@mrgrain mrgrain changed the title docs(cores): clarify exclude option on file and asset operations docs(core): clarify exclude option on file and asset operations Aug 9, 2022
@mrgrain mrgrain force-pushed the docs/asset-options branch from ce12478 to 5059a6a Compare August 9, 2022 10:04
@aws aws deleted a comment from aws-cdk-automation Aug 9, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 23a0b80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f2cf031 into aws:main Aug 9, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain deleted the docs/asset-options branch August 9, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants