Skip to content

chore(merge-back): 2.36.0#21512

Merged
mergify[bot] merged 4 commits intomainfrom
merge-back/2.36.0
Aug 8, 2022
Merged

chore(merge-back): 2.36.0#21512
mergify[bot] merged 4 commits intomainfrom
merge-back/2.36.0

Conversation

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation commented Aug 8, 2022

See CHANGELOG

kaizencc and others added 3 commits August 8, 2022 15:20
This is part of the Reduce Package Size [project](https://github.com/aws/aws-cdk/projects/15). Assembly compression is supported in jsii v1.64.0 (see this jsii [PR](aws/jsii#3570) for details + discussion about how compressed assemblies are handled). This PR includes the following:

- `--compress-assembly` flag turned on for `aws-cdk-lib` only
- `run-rosetta.sh` depends on `cdk-generate-synthetic-examples@^0.1.14` which is the minimum version with compressed assembly [support](cdklabs/cdk-generate-synthetic-examples#16).

----

This `--compress-assembly` flag was tested in the following way:

- this branch was pushed to `test-main-pipeline` and successfully built in the test pipeline.
- the build artifact was downloaded from s3, unzipped, and verified to have the correct `.jsii` and `.jsii.gz` structure in both TypeScript and Python.
- the build artifact was used to synth and deploy basic CDK apps in TypeScript and Python.
- the build artifact was privately published to a codeartifact repository.
- the codeartifact repository was used as a source to a local instance of construct hub.
- verified that the published library was ingested correctly by the ingestion lambda and shows up on construct hub.
- verified (via eye test, nothing too rigorous) that documentation was generated correctly on construct hub, including generated examples.

----

On code artifact, the package size shows up as 54 MB, compared to 194 MB, which is the size of the current package in npm.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Aug 8, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 8, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 8, 2022 22:05
@github-actions github-actions bot added the p2 label Aug 8, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 8, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b32e71e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 50ce07f into main Aug 8, 2022
@mergify mergify bot deleted the merge-back/2.36.0 branch August 8, 2022 22:44
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 8, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve p2 pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants