Skip to content

fix(cli): --hotswap does not handle CfnOutput change correctly#21461

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
tmokmss:no_hotswap_on_stack_output_changes
Aug 4, 2022
Merged

fix(cli): --hotswap does not handle CfnOutput change correctly#21461
mergify[bot] merged 2 commits intoaws:mainfrom
tmokmss:no_hotswap_on_stack_output_changes

Conversation

@tmokmss
Copy link
Copy Markdown
Contributor

@tmokmss tmokmss commented Aug 4, 2022 •
edited
Loading

closes #19998

Although there are other types of diffs (other than outputs) that are currently ignored by hotswap, I leave them as-is since no one is complaining about the behavior and it may break someone's hotswap experience.

aws-cdk/packages/@aws-cdk/cloudformation-diff/lib/diff/types.ts

Lines 10 to 21 in 3853728

export class TemplateDiff implements ITemplateDiff {
public awsTemplateFormatVersion?: Difference<string>;
public description?: Difference<string>;
public transform?: Difference<string>;
public conditions: DifferenceCollection<Condition, ConditionDifference>;
public mappings: DifferenceCollection<Mapping, MappingDifference>;
public metadata: DifferenceCollection<Metadata, MetadataDifference>;
public outputs: DifferenceCollection<Output, OutputDifference>;
public parameters: DifferenceCollection<Parameter, ParameterDifference>;
public resources: DifferenceCollection<Resource, ResourceDifference>;
/** The differences in unknown/unexpected parts of the template */
public unknown: DifferenceCollection<any, Difference<any>>;

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 4, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 4, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 4, 2022 14:15
@tmokmss tmokmss changed the title [cli] --hotswap does not see CfnOutput change fix(cli) --hotswap does not see CfnOutput change Aug 4, 2022
@mrgrain mrgrain changed the title fix(cli) --hotswap does not see CfnOutput change fix(cli): --hotswap does not see CfnOutput change Aug 4, 2022
@mrgrain mrgrain changed the title fix(cli): --hotswap does not see CfnOutput change fix(cli): --hotswap does not handle CfnOutput change correctly Aug 4, 2022
mrgrain
mrgrain approved these changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 4, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b92691e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ccc644 into aws:main Aug 4, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tmokmss tmokmss deleted the no_hotswap_on_stack_output_changes branch August 4, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

No one assigned

Labels

bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--hotswap does not see CfnOutput change

3 participants

@tmokmss @aws-cdk-automation @mrgrain