fix(ec2): launch template missing tags#21445
Conversation
|
|
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log (See Contributing Guide, Pull Requests).
Additionally, we'll need the build passing before we can provide a meaningful review.
Pull request has been modified.
87c7235 to
535ab77
Compare
535ab77 to
da0d3f0
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This change has unfortunately created a bit of a headache for us. We use CDK with EKS managed node groups, where we provide a launch template. Before this change our launch template didn't have the tags, but the resulting instances/volumes did (which was what we wanted). Now with this update, our launch template also gets the tags, which means a new version, which means all of our nodes have to roll out. 😞 There's no amount of hacking which we can think of to prevent this from happening. |
fixes #21440
Tags for
instanceandvolumewere forwarded but tags on thelaunch-templateitself were missingAll Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license