chore(iotevents): rename _bind from bind#21442
Conversation
|
|
|
Hey @yamatatsu thanks for the contribution. I'm feeling a bit lost here. What's the background to this? Did you have someone specific from the team in mind who should take a look here? |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
@yamatatsu No need to apologize! Thanks for picking this up even though you certainly didn't have to. @mrgrain I was being a bit grumpy that we hadn't requested a change on an interface when it was originally implemented and commented on that. It's our own convention that we weren't following. It was out of scope for that PR, though.
Just one place below where public wasn't set (suggested change inline).
Pull request has been modified.
|
Oops. I was wrong. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I apologize for my uncooperative comment in the previous PR.
I've refactored it!
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license