Skip to content

feat(opensearch): add support for latest amazon opensearch service 1.3#21413

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
prashanttct07:OpenSearch_1_3
Aug 2, 2022
Merged

feat(opensearch): add support for latest amazon opensearch service 1.3#21413
mergify[bot] merged 5 commits intoaws:mainfrom
prashanttct07:OpenSearch_1_3

Conversation

@prashanttct07
Copy link
Copy Markdown
Contributor

@prashanttct07 prashanttct07 commented Aug 1, 2022

fixes #21414
Description:
AWS Launched the support for Amazon OpenSearch Service 1.3 as per the announcement here: https://aws.amazon.com/about-aws/whats-new/2022/07/amazon-opensearch-service-supports-version-1-3/

AWS CDK does not support the latest version 1.3 yet, and this PR adds the support of Amazon OpenSearch Service 1.3 in CDK. Many people uses CDK to launch various AWS services and OpenSearch is one of them and having updated with latest version will help me to launch the Amazon OpenSearch Service using CDK.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 1, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 1, 2022 23:47
@github-actions github-actions bot added p2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 and removed p2 labels Aug 1, 2022
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log (See Contributing Guide, Pull Requests).

Additionally, make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process.

More specific to the code change, I see that OpenSearch also has 2.0 and 2.1. Can you add those as well?

@prashanttct07 prashanttct07 changed the title OpenSearch: Add support for OpenSearch 1.3 feat(opensearch): Add support for latest Amazon OpenSearch Service 1.3 Aug 2, 2022
@prashanttct07
Copy link
Copy Markdown
Contributor Author

I have updated the title as per the guideline. And updated the description.

Also, this is specific to launching an Amazon OpenSearch Service (managed service by AWS) using CDK which supports a maximum version upto 1.3.

OpenSearch 2.0 and 2.1 is there as part of OpenSearch Project (Open Source) but not there in service. We can add support of newer version in CDK as and when it becomes available with Amazon OpenSearch Service.

Let me know if anything else is needed for same.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 2, 2022 15:56

Pull request has been modified.

@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(opensearch): Add support for latest Amazon OpenSearch Service 1.3 feat(opensearch): add support for latest amazon opensearch service 1.3 Aug 2, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4876fe4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aa55715 into aws:main Aug 2, 2022
@prashanttct07 prashanttct07 deleted the OpenSearch_1_3 branch August 2, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenSearch: Add support for OpenSearch 1.3

3 participants