feat(lambda): add docker platform support for lambda#21405
feat(lambda): add docker platform support for lambda#21405mergify[bot] merged 17 commits intoaws:mainfrom
Conversation
…_image' into support_platform_flag_for_docker_image
|
Hi @yakirza17 thanks a lot for your contribution! We will definitely need some tests for this (unit + integration) and an example in the README. Additionally, since this is based on another PR, could you briefly explain if and how you've addressed the feedback that the original PR #16770 received? |
|
Hi @mrgrain, Most of the changes that were in the original PR have already entered main, the only change that is missing is in |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Please see the integration test documentation for writing new integration tests.
Pull request has been modified.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Just a few comments here inline. Please also review our documentation on writing PRs and make edits to align with those standards. Title is fine, body needs more details. Also, it looks like the issue that this should link is #20907
Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
Pull request has been modified.
Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
Pull request has been modified.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thanks for all your work on this!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Based on this PR
Add the missing part to add platform support when using lambda
fromImageAssetAs we are not allowed to specify
platformflag forDockerImageAsset, users deploying cdk on x86_64 platform will not be able to bundle lambda.DockerImageFunction for the new arm64 architecture. Similarly, users deploying cdk on arm64 architecture like Mac M1 will not be able to bundle images for AWS Fargate, which is x86_64 only.builder experience with aws-lambda
For x86_64 users deploying Lambda functions with container runtime on Lambda Graviton2(arm64) from local container image assets with multi-architecture docker base images. Specify the platform to ensure the image would be built for ARM64 architecture.
Fixes: #12472, #20907
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license