chore(ec2): update InitFile.fromObject tests with non-string data types#21394
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Jul 30, 2022
Merged
chore(ec2): update InitFile.fromObject tests with non-string data types#21394mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
approved these changes
Jul 30, 2022
Contributor
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Can't object to more testing being added!
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link: #14100
I tested described functionality and could not reproduce it with the latest version of cdk (commit 715158f).
Decided to update appropriate unit and integration tests for ec2.InitFile.fromObject to cover int, bool, number types as well as string.
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license