fix(cognito): UserPoolClient doesn't correctly respect authFlows#21386
fix(cognito): UserPoolClient doesn't correctly respect authFlows#21386mergify[bot] merged 3 commits intoaws:mainfrom msysh:main
Conversation
Currently, `ALLOW_CUSTOM_AUTH` and `ALLOW_USER_SRP_AUTH` are always enabled if all authFlows properties are provided with false. This change fixes that.
|
|
|
No need to merge main into this. Mergify will do that for us. |
|
I'm a bit concerned that integration tests didn't pick up this bug in the first place or the change, but I think the unit tests cover the same thing an integ test would so I'm not going to ask for one. This is good to go. Thank you for your contribution. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Currently,
ALLOW_CUSTOM_AUTHandALLOW_USER_SRP_AUTHare always enabled if all authFlows properties are provided with false. This change fixes that.closes #16236
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license