Skip to content

fix(lambda-nodejs):false compiler options are not passed tsc#21377

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
hassanazharkhan:fix/20670
Aug 4, 2022
Merged

fix(lambda-nodejs):false compiler options are not passed tsc#21377
mergify[bot] merged 2 commits intoaws:mainfrom
hassanazharkhan:fix/20670

Conversation

@hassanazharkhan
Copy link
Copy Markdown
Contributor

@hassanazharkhan hassanazharkhan commented Jul 29, 2022

Any option that is set to false is omitted from the tsc command line options. This results in failed compilations during cdk synthesis whereas building directly with tsc does not fail.

closes #20670


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 29, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jul 29, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2022 11:58
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log.

Additionally, please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process (See Contributing Guide, Pull Requests)

@hassanazharkhan hassanazharkhan changed the title fix(lambda-nodejs): during preCompilation, set false flags for tsc compiler options fix(lambda-nodejs): allow false compiler options to passed to tsc during preCompilation Aug 2, 2022
@hassanazharkhan hassanazharkhan changed the title fix(lambda-nodejs): allow false compiler options to passed to tsc during preCompilation fix(lambda-nodejs): allow false compiler options to pass to tic Aug 2, 2022
@hassanazharkhan hassanazharkhan changed the title fix(lambda-nodejs): allow false compiler options to pass to tic fix(lambda-nodejs): allow false compiler options to pass to tsc Aug 2, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(lambda-nodejs): allow false compiler options to pass to tsc fix(lambda-nodejs):false compiler options are not passed tsc Aug 4, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f432c9d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cef98cf into aws:main Aug 4, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-lambda-nodejs: During precompilation, set false flags for tsc compiler options

3 participants